Fix 500 on recipe save and surface errors as notifications
Deploy / deploy (push) Successful in 14s

- Fix root cause: recipes_spices.amount_in_percent was decimal(4,2) which
  overflows on 100% — widened to decimal(6,2) via migration
- Wrap afterSave() in try-catch so DB/logic errors show as a persistent
  danger notification instead of a blank 500 page
- Same for CreateProduct: errors show as notification; also reads
  recipe_spices from raw Livewire $this->data (not $data param which
  excludes dehydrated(false) fields) so recipes actually save on create

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Malek TellissiandClaude Sonnet 4.6 committed 2026-09-12 18:19:31 +02:00
1 parent 811f5a015e
commit 3301a1e9b2
3 files changed
+77 -31

No files matched your search

@@ -5,6 +5,7 @@ namespace App\Filament\User\Resources\ProductResource\Pages;
use App\Filament\User\Resources\ProductResource; use App\Filament\User\Resources\ProductResource;
use App\Models\ProductSize; use App\Models\ProductSize;
use App\Models\Recipe; use App\Models\Recipe;
use Filament\Notifications\Notification;
use Filament\Resources\Pages\CreateRecord; use Filament\Resources\Pages\CreateRecord;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
@@ -14,36 +15,50 @@ class CreateProduct extends CreateRecord
protected function handleRecordCreation(array $data): Model protected function handleRecordCreation(array $data): Model
{ {
$record = static::getModel()::create($data); $sizes = $data['sizes'] ?? [];
$spices = $this->data['recipe_spices'] ?? [];
unset($data['sizes']);
foreach ($data['sizes'] ?? [] as $size) { try {
ProductSize::create([ $record = static::getModel()::create($data);
'product_id' => $record->id,
'packing_id' => $size['packing_id'], foreach ($sizes as $size) {
'description' => $size['description'] ?? null, if (empty($size['packing_id'])) {
'price' => $size['price'], continue;
'sku' => $size['sku'] ?? null, }
'gtin' => $size['gtin'] ?? null, $gtin = preg_replace('/\D/', '', (string) ($size['gtin'] ?? ''));
]); ProductSize::create([
'product_id' => $record->id,
'packing_id' => (int) $size['packing_id'],
'description' => $size['description'] ?? null,
'price' => $size['price'],
'sku' => $size['sku'] ?: null,
'gtin' => $gtin !== '' ? $gtin : null,
]);
}
if (! empty($spices)) {
$recipe = Recipe::create([
'name' => $data['title'],
'product_id' => $record->id,
'version' => 1,
]);
$pivotData = collect($spices)->mapWithKeys(fn ($s) => [
(int) $s['spice_id'] => ['amount_in_percent' => (float) $s['amount_in_percent']],
])->toArray();
$recipe->spices()->sync($pivotData);
$record->update(['recipes_id' => $recipe->id]);
}
return $record;
} catch (\Throwable $e) {
Notification::make()
->title('Fehler beim Anlegen')
->body($e->getMessage())
->danger()
->persistent()
->send();
throw $e;
} }
$spices = $data['recipe_spices'] ?? [];
if (! empty($spices)) {
$recipe = Recipe::create([
'name' => $data['title'],
'product_id' => $record->id,
'version' => 1,
]);
$pivotData = collect($spices)->mapWithKeys(fn ($s) => [
$s['spice_id'] => ['amount_in_percent' => $s['amount_in_percent']],
])->toArray();
$recipe->spices()->sync($pivotData);
$record->update(['recipes_id' => $recipe->id]);
}
return $record;
} }
} }
@@ -51,8 +51,17 @@ class EditProduct extends EditRecord
protected function afterSave(): void protected function afterSave(): void
{ {
$this->syncSizes(); try {
$this->syncRecipe(); $this->syncSizes();
$this->syncRecipe();
} catch (\Throwable $e) {
Notification::make()
->title('Fehler beim Speichern')
->body($e->getMessage())
->danger()
->persistent()
->send();
}
} }
protected function syncSizes(): void protected function syncSizes(): void
@@ -0,0 +1,22 @@
<?php
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;
return new class extends Migration
{
public function up(): void
{
Schema::table('recipes_spices', function (Blueprint $table) {
$table->decimal('amount_in_percent', 6, 2)->change();
});
}
public function down(): void
{
Schema::table('recipes_spices', function (Blueprint $table) {
$table->decimal('amount_in_percent', 4, 2)->change();
});
}
};